fix prometheus: escape backslash and newline in label values - #1268
Closed
netliomax25-code wants to merge 1 commit into
Closed
fix prometheus: escape backslash and newline in label values#1268netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
netliomax25-code
force-pushed
the
prometheus-label-escape
branch
from
June 29, 2026 07:46
04a29c2 to
b28505f
Compare
Member
|
LGTM |
|
Many thanks for the PR! @apolukhin is now importing your pull request into our internal upstream repository. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Jul 29, 2026
1. DumpLabelsRaw escapes only `"` (to `'`) in Prometheus label values, leaving backslash and line feeds raw. 2. A value ending in `\` then escapes the closing quote so the rest of the line is pulled into the value, and an embedded line feed starts a new sample line. Added AppendEscapedLabelValue to double `\` and write line feeds as `\n`, matching how the Graphite and Solomon writers already neutralize these characters. Covered both cases with a regression test. --- Pull Request resolved: #1268 Co-authored-by: “rootvector2” <“dxbnaveed.k@gmail.com”> commit_hash:56d9bfdaee7a934cba9b149dbce1b6f2a205a104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"(to') in Prometheus label values, leaving backslash and line feeds raw.\then escapes the closing quote so the rest of the line is pulled into the value, and an embedded line feed starts a new sample line.Added AppendEscapedLabelValue to double
\and write line feeds as\n, matching how the Graphite and Solomon writers already neutralize these characters. Covered both cases with a regression test.